Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): Remove implicit reverse from AExpr::replace_inputs() #20659

Merged
merged 1 commit into from
Jan 10, 2025
Merged

refactor(rust): Remove implicit reverse from AExpr::replace_inputs() #20659

merged 1 commit into from
Jan 10, 2025
+37 −47

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 10, 2025 •
edited
Loading

Also clarifies that AExpr::nodes iterates over the input nodes in reverse order by renaming it to AExpr::inputs_rev.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 10, 2025
@ritchie46 ritchie46 merged commit 17556e4 into pola-rs:main Jan 10, 2025
23 checks passed
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (8abd261) to head (148dc9b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/aexpr/traverse.rs 66.66% 7 Missing ⚠️
crates/polars-plan/src/plans/aexpr/properties.rs 50.00% 1 Missing ⚠️
...rs-plan/src/plans/optimizer/slice_pushdown_expr.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20659      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.01%     
==========================================
  Files        1557     1557              
  Lines      220696   220743      +47     
  Branches     2517     2527      +10     
==========================================
+ Hits       174297   174315      +18     
- Misses      45825    45850      +25     
- Partials      574      578       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orlp @ritchie46